[
https://issues.apache.org/jira/browse/HADOOP-9721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13705259#comment-13705259
]
Hadoop QA commented on HADOOP-9721:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12591761/HADOOP-9721.1.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-hdfs-project/hadoop-hdfs-httpfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2764//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/2764//console
This message is automatically generated.
> Incorrect logging.properties file for hadoop-httpfs
> ---------------------------------------------------
>
> Key: HADOOP-9721
> URL: https://issues.apache.org/jira/browse/HADOOP-9721
> Project: Hadoop Common
> Issue Type: Bug
> Components: build, conf
> Affects Versions: 2.0.4-alpha
> Environment: Maven 3.0.2 on CentOS6.2
> Reporter: Mark Grover
> Fix For: 3.0.0, 2.1.0-beta
>
> Attachments: HADOOP-9721.1.patch
>
>
> Tomcat ships with a default logging.properties file that's generic enough to
> be used however we already override it with a custom log file as seen at
> https://github.com/apache/hadoop-common/blob/trunk/hadoop-hdfs-project/hadoop-hdfs-httpfs/pom.xml#L557
> This is necessary because we can have the log locations controlled by
> httpfs.log.dir env variable (instead of default catalina.base/logs), control
> the prefix of the log files names, etc.
> In any case, this overriding doesn't always happen. In my environment, the
> custom logging.properties file doesn't get overridden. The reason is the
> destination logging.properties file already exists and the maven pom's copy
> command silently fails and doesn't override. If we explicitly delete the
> destination logging.properties file, then the copy command successfully
> completes. You may notice, we do the same thing with server.xml (which
> doesn't have this problem). We explicitly delete the destination file first
> and then copy it over. We should do the same with logging.properties as well.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
