[ 
https://issues.apache.org/jira/browse/HADOOP-8873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13706661#comment-13706661
 ] 

Suresh Srinivas commented on HADOOP-8873:
-----------------------------------------

I ran unit tests with this patch. It causes org.apache.hadoop.cli.TestCLI to 
fail. Once that is addressed, I can commit it. Here are the failing tests:
{quote}
2013-07-11 22:25:53,624 INFO  cli.TestCLI (TestCLI.java:displayResults(192)) - 
-------------------------------------------
2013-07-11 22:25:53,624 INFO  cli.TestCLI (TestCLI.java:displayResults(193)) -  
                   Test ID: [104]
2013-07-11 22:25:53,624 INFO  cli.TestCLI (TestCLI.java:displayResults(194)) -  
          Test Description: [mkdir: creating a directory with the name of an 
already existing directory]
2013-07-11 22:25:53,624 INFO  cli.TestCLI (TestCLI.java:displayResults(195)) - 
2013-07-11 22:25:53,625 INFO  cli.TestCLI (TestCLI.java:displayResults(199)) -  
             Test Commands: [-fs hdfs://localhost:59613 -mkdir /dir0]
2013-07-11 22:25:53,625 INFO  cli.TestCLI (TestCLI.java:displayResults(199)) -  
             Test Commands: [-fs hdfs://localhost:59613 -mkdir /dir0]
2013-07-11 22:25:53,625 INFO  cli.TestCLI (TestCLI.java:displayResults(203)) - 
2013-07-11 22:25:53,625 INFO  cli.TestCLI (TestCLI.java:displayResults(206)) -  
          Cleanup Commands: [-fs hdfs://localhost:59613 -rmr /dir0]
2013-07-11 22:25:53,625 INFO  cli.TestCLI (TestCLI.java:displayResults(210)) - 
2013-07-11 22:25:53,625 INFO  cli.TestCLI (TestCLI.java:displayResults(214)) -  
                Comparator: [TokenComparator]
2013-07-11 22:25:53,625 INFO  cli.TestCLI (TestCLI.java:displayResults(216)) -  
        Comparision result:   [fail]
2013-07-11 22:25:53,625 INFO  cli.TestCLI (TestCLI.java:displayResults(218)) -  
           Expected output:   [mkdir: cannot create directory /dir0: File 
exists]
2013-07-11 22:25:53,625 INFO  cli.TestCLI (TestCLI.java:displayResults(220)) -  
             Actual output:   [mkdir: /dir0: File exists
]
2013-07-11 22:25:53,625 INFO  cli.TestCLI (TestCLI.java:displayResults(223)) - 
2013-07-11 22:25:53,625 INFO  cli.TestCLI (TestCLI.java:displayResults(192)) - 
-------------------------------------------
2013-07-11 22:25:53,625 INFO  cli.TestCLI (TestCLI.java:displayResults(193)) -  
                   Test ID: [105]
2013-07-11 22:25:53,625 INFO  cli.TestCLI (TestCLI.java:displayResults(194)) -  
          Test Description: [mkdir: creating a directory with the name of an 
already existing file]
2013-07-11 22:25:53,625 INFO  cli.TestCLI (TestCLI.java:displayResults(195)) - 
2013-07-11 22:25:53,626 INFO  cli.TestCLI (TestCLI.java:displayResults(199)) -  
             Test Commands: [-fs hdfs://localhost:59613 -put 
file:/Users/suresh/Documents/workspace/1/build/test/cache//data15bytes 
data15bytes]
2013-07-11 22:25:53,626 INFO  cli.TestCLI (TestCLI.java:displayResults(199)) -  
             Test Commands: [-fs hdfs://localhost:59613 -mkdir data15bytes]
2013-07-11 22:25:53,626 INFO  cli.TestCLI (TestCLI.java:displayResults(203)) - 
2013-07-11 22:25:53,626 INFO  cli.TestCLI (TestCLI.java:displayResults(206)) -  
          Cleanup Commands: [-fs hdfs://localhost:59613 -rmr data15bytes]
2013-07-11 22:25:53,626 INFO  cli.TestCLI (TestCLI.java:displayResults(210)) - 
2013-07-11 22:25:53,626 INFO  cli.TestCLI (TestCLI.java:displayResults(214)) -  
                Comparator: [TokenComparator]
2013-07-11 22:25:53,626 INFO  cli.TestCLI (TestCLI.java:displayResults(216)) -  
        Comparision result:   [fail]
2013-07-11 22:25:53,626 INFO  cli.TestCLI (TestCLI.java:displayResults(218)) -  
           Expected output:   [mkdir: data15bytes exists but is not a directory]
2013-07-11 22:25:53,626 INFO  cli.TestCLI (TestCLI.java:displayResults(220)) -  
             Actual output:   [mkdir: data15bytes: Is not a directory
]
{quote}
                
> Port HADOOP-8175 (Add mkdir -p flag) to branch-1
> ------------------------------------------------
>
>                 Key: HADOOP-8873
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8873
>             Project: Hadoop Common
>          Issue Type: Improvement
>    Affects Versions: 1.2.0
>            Reporter: Eli Collins
>            Assignee: Akira AJISAKA
>              Labels: newbie
>         Attachments: HADOOP-8873-1.patch, HADOOP-8873-2.patch, 
> HADOOP-8873-3.patch
>
>
> Per HADOOP-8551 let's port the mkdir -p option to branch-1 for a 1.x release 
> to help users transition to the new shell behavior. In Hadoop 2.x mkdir 
> currently requires the -p option to create parent directories but a program 
> that specifies it won't work on 1.x since it doesn't support this option.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to