[
https://issues.apache.org/jira/browse/HADOOP-9652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13707262#comment-13707262
]
Colin Patrick McCabe commented on HADOOP-9652:
----------------------------------------------
Looks good. I am glad to see that {{DelegateToFileSystem}} is now delegating
the symlinks methods-- good idea.
{code}
- assertEquals(FsPermission.getDefault(), fsd.getPermission());
{code}
This test case should be still applicable, right? Symlinks created by the test
user should be owned by him.
{code}
+ public static final OSType osType;
+
+ static {
+ osType = getOSType();
+ }
{code}
This can al be combined into one line.
> RawLocalFs#getFileLinkStatus does not fill in the link owner and mode
> ---------------------------------------------------------------------
>
> Key: HADOOP-9652
> URL: https://issues.apache.org/jira/browse/HADOOP-9652
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Colin Patrick McCabe
> Assignee: Andrew Wang
> Attachments: hadoop-9452-1.patch
>
>
> {{RawLocalFs#getFileLinkStatus}} does not actually get the owner and mode of
> the symlink, but instead uses the owner and mode of the symlink target. If
> the target can't be found, it fills in bogus values (the empty string and
> FsPermission.getDefault) for these.
> Symlinks have an owner distinct from the owner of the target they point to,
> and getFileLinkStatus ought to expose this.
> In some operating systems, symlinks can have a permission other than 0777.
> We ought to expose this in RawLocalFilesystem and other places, although we
> don't necessarily have to support this behavior in HDFS.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
