[
https://issues.apache.org/jira/browse/HADOOP-9763?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13717104#comment-13717104
]
Jing Zhao commented on HADOOP-9763:
-----------------------------------
The patch looks very good to me. Only some minors:
1. TestLightWeightCache.java, it would be better if more javadoc/comments can
be added to TestLightWeightCache, such as the general steps for each check
process, and what is tested for each step.
2. Maybe we can assign an initial random value for
LightWeightCacheTestCase#currentTestTime?
> Extends LightWeightGSet to support eviction of expired elements
> ---------------------------------------------------------------
>
> Key: HADOOP-9763
> URL: https://issues.apache.org/jira/browse/HADOOP-9763
> Project: Hadoop Common
> Issue Type: New Feature
> Components: util
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: c9763_20130723b.patch, c9763_20130723.patch,
> h5017_20130721.patch, h5017_20130722b.patch, h5017_20130722.patch
>
>
> We extends LightWeightGSet to support eviction of expired elements so that
> namenode could use it as the RetryCache.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
