[
https://issues.apache.org/jira/browse/HADOOP-9768?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13719949#comment-13719949
]
Chris Nauroth commented on HADOOP-9768:
---------------------------------------
Thanks, Ravi. I've uploaded version 3 of the patches to allow space only on
Windows. I've also fixed the failure in {{TestCLI}}. There is no way to
express conditional logic based on platform in testConf.xml, so I'm using a
wildcard to match the allowable characters. We now need a separate patch for
branch-1-win. The branch-1 patch won't apply cleanly to branch-1-win due to a
minor difference in imports in the test class.
However, I'm now wondering why the Hadoop code is attempting to duplicate
validation rules that are enforced at the OS and inconsistent across OSes.
This validation code is over 5 years old, and I haven't been able to trace the
history of why we're doing it. I'm pretty sure the current code isn't even
correct across different Unixes, especially when you consider the possibility
of customization via PAM modules. If we just pass through to the OS and let it
report validation failures, then we can remove this portability/maintenance
burden. Of course, this would be a longer-term consideration. For right now,
I'm interested to hear if the current patches look acceptable.
> chown and chgrp reject users and groups with spaces on platforms where spaces
> are otherwise acceptable
> ------------------------------------------------------------------------------------------------------
>
> Key: HADOOP-9768
> URL: https://issues.apache.org/jira/browse/HADOOP-9768
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 3.0.0, 1-win, 2.1.0-beta, 1.3.0
> Reporter: Chris Nauroth
> Assignee: Chris Nauroth
> Attachments: HADOOP-9768-branch-1.1.patch,
> HADOOP-9768-branch-1.2.patch, HADOOP-9768-branch-1.3.patch,
> HADOOP-9768-branch-1-win.3.patch, HADOOP-9768-trunk.1.patch,
> HADOOP-9768-trunk.2.patch, HADOOP-9768-trunk.3.patch
>
>
> The chown and chgrp commands enforce a check on a valid set of characters for
> user and group. The set of valid characters does not include space. On some
> platforms (notably Windows), the space character is acceptable. We've seen
> this cause test failures in {{TestFsShellReturnCode}} when running on Windows
> if the logged-in user is a member of a group like Remote Desktop Users.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
