[
https://issues.apache.org/jira/browse/HADOOP-9822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13729698#comment-13729698
]
Colin Patrick McCabe commented on HADOOP-9822:
----------------------------------------------
Looks fine to me. Can we have the constant in caps, like usual?
> create constant maxCapacity in RetryCache rather than hard-coding 16 in
> RetryCache constructor
> ----------------------------------------------------------------------------------------------
>
> Key: HADOOP-9822
> URL: https://issues.apache.org/jira/browse/HADOOP-9822
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 3.0.0, 2.3.0, 2.1.1-beta
> Reporter: Tsuyoshi OZAWA
> Assignee: Tsuyoshi OZAWA
> Priority: Minor
> Attachments: HADOOP-9822.1.patch
>
>
> The magic number "16" is also used in ClientId.BYTE_LENGTH, so hard-coding
> magic number "16" is a bit confusing.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
