[ 
https://issues.apache.org/jira/browse/HADOOP-9832?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Daryn Sharp updated HADOOP-9832:
--------------------------------

    Attachment: HADOOP-9832.patch

The test protocol is a mistake.  It's importing 
{{TestSaslRPC.TestSaslProtocol}} which subclasses the {{TestProtocol}} used by 
the proxy in this test.  Benign but unnecessary so I'll remove it.

Checking the debug level is valuable if the log message would require throwaway 
computation if the log level is disabled.  However, the first thing 
{{LOG.debug}} does is check if the debug level is enabled so explicitly 
checking for a static message actually causes more work.
                
> Add RPC header to client ping
> -----------------------------
>
>                 Key: HADOOP-9832
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9832
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: ipc
>    Affects Versions: 2.0.0-alpha, 3.0.0
>            Reporter: Daryn Sharp
>            Assignee: Daryn Sharp
>            Priority: Blocker
>         Attachments: HADOOP-9832.patch, HADOOP-9832.patch
>
>
> Splitting out the ping part of the umbrella jira.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to