[
https://issues.apache.org/jira/browse/HADOOP-9802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13735772#comment-13735772
]
Chris Nauroth commented on HADOOP-9802:
---------------------------------------
Chuan, reviewing the HADOOP-8907 patch, I can't see how this code would help.
It would try to load snappy.dll by absolute path of the directory containing
hadoop.dll. With the bundle.snappy flag, people can choose to package
snappy.dll in the same directory as hadoop.dll in the distribution. If the
process was able to load hadoop.dll (either via java.library.path or PATH),
then it must be able to load any other dll in the same directory without
needing to determine the absolute path.
One thing I wondered about was whether specifying java.library.path (not the
PATH environment variable) would propagate down to the search path used for the
{{LoadLibrary}} call at the native layer. If not, then the HADOOP-8907 patch
would be helpful for users who bundle Snappy but don't want to change their
PATH. However, I tested this scenario by making sure hadoop.dll and snappy.dll
were not in my PATH, running "hadoop.cmd checknative", and observing that the
native libraries were loaded. It appears that there is no special handling
required to support this.
At this point, I can't think of a scenario where the extra code would help. If
you can think of an example, then do you mind if we handle it in a separate
jira? This patch is already fairly large, and doing it in a separate jira
would make the code reviews easier.
> Support Snappy codec on Windows.
> --------------------------------
>
> Key: HADOOP-9802
> URL: https://issues.apache.org/jira/browse/HADOOP-9802
> Project: Hadoop Common
> Issue Type: Improvement
> Components: io
> Affects Versions: 3.0.0, 1-win, 2.1.1-beta
> Reporter: Chris Nauroth
> Assignee: Chris Nauroth
> Attachments: HADOOP-9802-branch-1-win.1.patch,
> HADOOP-9802-trunk.1.patch, HADOOP-9802-trunk.2.patch,
> HADOOP-9802-trunk.3.patch
>
>
> Build and test the existing Snappy codec on Windows.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
