[
https://issues.apache.org/jira/browse/HADOOP-9583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13736926#comment-13736926
]
Jason Lowe commented on HADOOP-9583:
------------------------------------
bq. With HADOOP-9853, surefire timeout cases can be dealt with, but 1) the
script cannot rely on the exit code for failures and 2) any other types of test
process failures are not covered (e.g. something causing System.exit()).
The separate modules are run as separate Maven invocations, so we should be
fine there. If one module build fails it should proceed to the next one. Also
surefire runs all the tests in the module even if one or more times out or
exits unexpectedly, so as long as we're not telling surefire to ignore those
cases it should continue to return a non-zero exit code.
> test-patch gives +1 despite build failure when running tests
> ------------------------------------------------------------
>
> Key: HADOOP-9583
> URL: https://issues.apache.org/jira/browse/HADOOP-9583
> Project: Hadoop Common
> Issue Type: Bug
> Affects Versions: 3.0.0
> Reporter: Jason Lowe
> Assignee: Jason Lowe
> Priority: Critical
> Attachments: HADOOP-9583.another_dummy.patch,
> HADOOP-9583-dummy.patch, HADOOP-9583-dummy.patch,
> HADOOP-9583-dummy-without-changes.patch, HADOOP-9583.patch
>
>
> I've seen a couple of checkins recently where tests have timed out resulting
> in a Maven build failure yet test-patch reports an overall +1 on the patch.
> This is encouraging commits of patches that subsequently break builds.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
