[ 
https://issues.apache.org/jira/browse/HADOOP-9887?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13747043#comment-13747043
 ] 

Chris Nauroth commented on HADOOP-9887:
---------------------------------------

bq. One problem is that we will lost the drive letter from the components; and 
we will list directories from "/" instead of "/C:/".

That's a good point.  I missed this part, so thanks for the explanation.

Just one more minor nit on the patch: I think usage of {{"/"}} and {{"."}} in 
this {{Globber}} logic should be replaced with {{Path.SEPARATOR}} and 
{{Path.CUR_DIR}}.  With that change, I'll be +1.
                
> globStatus does not correctly handle paths starting with a drive spec on 
> Windows
> --------------------------------------------------------------------------------
>
>                 Key: HADOOP-9887
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9887
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 3.0.0, 2.3.0
>            Reporter: Chris Nauroth
>            Assignee: Chuan Liu
>         Attachments: HADOOP-9887-trunk.patch
>
>
> Recent file system changes have caused globStatus to stop working for paths 
> starting with a drive spec on Windows.  The problem is most easily visible by 
> running {{TestFileUtil#createJarWithClassPath}} on Windows.  This method 
> attempts a globStatus with pattern {{*\{.jar,.JAR\}}}, and it no longer 
> correctly identifies files at the path ending in .jar or .JAR.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to