[
https://issues.apache.org/jira/browse/HADOOP-9913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13753473#comment-13753473
]
Tsuyoshi OZAWA commented on HADOOP-9913:
----------------------------------------
+1, the policy to fix LGTM.
Two comment:
1. Can you understand what "Queue time" stands for? If your answer is positive,
it's OK. However, IMHO, "Time in server side queue" is more appropriate
expression.
2. The patch against hadoop-common-project and hadoop-hdfs-project can be split.
> Document time unit to metrics
> -----------------------------
>
> Key: HADOOP-9913
> URL: https://issues.apache.org/jira/browse/HADOOP-9913
> Project: Hadoop Common
> Issue Type: Improvement
> Components: documentation, metrics
> Affects Versions: 3.0.0, 2.1.0-beta
> Environment: trunk
> Reporter: Akira AJISAKA
> Assignee: Akira AJISAKA
> Priority: Minor
> Labels: newbie
> Attachments: HADOOP-9913.patch
>
>
> For example, in o.a.h.hdfs.server.namenode.metrics.NameNodeMetrics.java,
> metrics are declared as follows:
> {code}
> @Metric("Duration in SafeMode at startup") MutableGaugeInt safeModeTime;
> @Metric("Time loading FS Image at startup") MutableGaugeInt fsImageLoadTime;
> {code}
> Since some users may confuse which unit (sec or msec) is correct, they should
> be documented.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
