[
https://issues.apache.org/jira/browse/HADOOP-9918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13754072#comment-13754072
]
Steve Loughran commented on HADOOP-9918:
----------------------------------------
seems good, though some javadocs on the method would be nice
> Add addIfService() to CompositeService
> --------------------------------------
>
> Key: HADOOP-9918
> URL: https://issues.apache.org/jira/browse/HADOOP-9918
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 2.1.0-beta
> Reporter: Karthik Kambatla
> Assignee: Karthik Kambatla
> Priority: Minor
> Labels: service
> Attachments: hadoop-9918-1.patch, hadoop-9918-2.patch
>
>
> Some YARN and MR classes implement their own version of {{addIfService(Object
> object)}} that adds the service to CompositeService if the object is a
> service.
> It makes more sense to move this helper to CompositeService itself.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
