[ 
https://issues.apache.org/jira/browse/HADOOP-9913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13754261#comment-13754261
 ] 

Hadoop QA commented on HADOOP-9913:
-----------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12600696/HADOOP-9913.2.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+0 tests included{color}.  The patch appears to be a 
documentation patch that doesn't require tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-common-project/hadoop-common.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/3041//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/3041//console

This message is automatically generated.
                
> Document time unit to RpcMetrics.java
> -------------------------------------
>
>                 Key: HADOOP-9913
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9913
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: documentation, metrics
>    Affects Versions: 3.0.0, 2.1.0-beta
>         Environment: trunk
>            Reporter: Akira AJISAKA
>            Assignee: Akira AJISAKA
>            Priority: Minor
>              Labels: newbie
>         Attachments: HADOOP-9913.2.patch, HADOOP-9913.patch
>
>
> In o.a.h.ipc.metrics.RpcMetrics.java, metrics are declared as follows:
> {code}
>    @Metric("Queue time") MutableRate rpcQueueTime;
>    @Metric("Processsing time") MutableRate rpcProcessingTime;
> {code}
> Since some users may confuse which unit (sec or msec) is correct, they should 
> be documented.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to