[
https://issues.apache.org/jira/browse/HADOOP-9332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13760393#comment-13760393
]
Luke Lu commented on HADOOP-9332:
---------------------------------
Preliminary comments:
* I had to dig to find out that both SimpleAESCodec and AESCodec are using CTR
mode, which is fine. I was thrown off by the comment in the beginning of the
SimpleAESCodec, as we know AES in the default ECB mode is pretty much
worthless. Suggest rename the codec to AESCTRCodec, unless you're going to
support other modes (CBC etc.), which requires an explicit comment.
* There is much code duplication between SimpleAESCodec (without compressor
option) and AESCodec (with compressor option). Suggest consolidate code in one
codec.
> Crypto codec implementations for AES
> ------------------------------------
>
> Key: HADOOP-9332
> URL: https://issues.apache.org/jira/browse/HADOOP-9332
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: security
> Affects Versions: 3.0.0
> Reporter: Yi Liu
> Fix For: 3.0.0
>
> Attachments: HADOOP-9332.patch, HADOOP-9332.patch
>
>
> This JIRA task provides three crypto codec implementations based on the
> Hadoop crypto codec framework. They are:
> 1. Simple AES Codec. AES codec implementation based on AES-NI. (Not
> splittable)
> 2. AES Codec. AES codec implementation based on AES-NI in splittable
> format.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
