[ 
https://issues.apache.org/jira/browse/HADOOP-9945?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13762327#comment-13762327
 ] 

Hadoop QA commented on HADOOP-9945:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12602206/hadoop-9945-1.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-common-project/hadoop-common.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/3073//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/3073//console

This message is automatically generated.
                
> HAServiceState should have a state for stopped services
> -------------------------------------------------------
>
>                 Key: HADOOP-9945
>                 URL: https://issues.apache.org/jira/browse/HADOOP-9945
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: ha
>    Affects Versions: 2.1.0-beta
>            Reporter: Karthik Kambatla
>            Assignee: Karthik Kambatla
>            Priority: Minor
>         Attachments: hadoop-9945-1.patch
>
>
> HAServiceState, currently, has states for Initializing, Active, and Standby. 
> For RM HA, it is useful to have another state "STOPPING". This is because 
> YARN has a separate service model where Services are stopped and can't be 
> restarted. When the Active/Standby RM is stopped, it can no longer go back to 
> the Active/Standby state; setting the HAServiceState to Initializing is 
> misleading.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to