[
https://issues.apache.org/jira/browse/HADOOP-9704?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13781494#comment-13781494
]
Luke Lu commented on HADOOP-9704:
---------------------------------
Thanks for the patch, Alex and Chu! Both of you will be credited :)
Feedback for the latest patch:
# There is no need to do context filtering in a sink implemention, as metrics
filtering is provided by framework itself for any sinks. Though currently,
context filtering is either all or a particular context, though individual
record and metrics can handle glob patterns. File another JIRA for support
context globbing (simple to implement) if that's what you want.
# Use StringBuilder instead of StringBuffer as the buffer is not shared across
threads, hence no need to pay the synchronized penalty.
# ArgumentCaptor<String> should work with a mockito mock writer (use
#getAllValues to access values from multiple invocations). There is no need to
do manual capture.
> Write metrics sink plugin for Hadoop/Graphite
> ---------------------------------------------
>
> Key: HADOOP-9704
> URL: https://issues.apache.org/jira/browse/HADOOP-9704
> Project: Hadoop Common
> Issue Type: New Feature
> Affects Versions: 2.0.3-alpha
> Reporter: Chu Tong
> Attachments:
> 0001-HADOOP-9704.-Write-metrics-sink-plugin-for-Hadoop-Gr.patch,
> HADOOP-9704.patch, HADOOP-9704.patch
>
>
> Write a metrics sink plugin for Hadoop to send metrics directly to Graphite
> in additional to the current ganglia and file ones.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
