[
https://issues.apache.org/jira/browse/HADOOP-9199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13784054#comment-13784054
]
Robert Parker commented on HADOOP-9199:
---------------------------------------
[~vbondarev] thanks for the patch, one small change:
for the TestEnumWritable#testEnumSetWritableWriteRead:
The readFields operation should go to a new EnumWritableSet so the source
in not contaminated by the read. For example:
{code}
EnumSetWritable<TestEnumSet> eset =
new EnumSetWritable<TestEnumSet>(EnumSet.of(TestEnumSet.APPEND,
TestEnumSet.CREATE), TestEnumSet.class);
EnumSetWritable<TestEnumSet> oset = new EnumSetWritable<TestEnumSet>();
eset.write(out);
in.reset(out.getData(), out.getLength());
oset.readFields(in);
EnumSet<TestEnumSet> result = oset.get();
{code}
> Cover package org.apache.hadoop.io with unit tests
> --------------------------------------------------
>
> Key: HADOOP-9199
> URL: https://issues.apache.org/jira/browse/HADOOP-9199
> Project: Hadoop Common
> Issue Type: Test
> Affects Versions: 3.0.0, 2.0.3-alpha, 0.23.6
> Reporter: Vadim Bondarev
> Assignee: Vadim Bondarev
> Attachments: HADOOP-9199-branch-0.23-a.patch,
> HADOOP-9199-branch-0.23-b.patch, HADOOP-9199-branch-0.23-c.patch,
> HADOOP-9199-branch-0.23-e.patch, HADOOP-9199-branch-2-a.patch,
> HADOOP-9199-branch-2-b.patch, HADOOP-9199-branch-2-c.patch,
> HADOOP-9199-branch-2-e.patch, HADOOP-9199-trunk-a.patch,
> HADOOP-9199-trunk-b.patch, HADOOP-9199-trunk-c.patch,
> HADOOP-9199-trunk-e.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.1#6144)