[ 
https://issues.apache.org/jira/browse/HADOOP-10020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13787240#comment-13787240
 ] 

Chris Nauroth commented on HADOOP-10020:
----------------------------------------

Hi, [~sanjay.radia].  Thanks for picking up this patch so quickly.  I think it 
looks good.  Here are just a couple of small things:

# Can we add {{@Deprecated}} tags on {{FileSystem#isSymlinksEnabled}} and 
{{FileSystem#enableSymlinks}}?  That way, clients will get warnings if they try 
to call them directly.
# Shall we add a call to {{FileSystem#isSymlinksEnabled}} in 
{{FSNamesystem#createSymlink}} too?  Right now, the enforcement happens 
client-side in the {{FileSystem}} subclasses.  If someone connects a 2.1.x 
client to a 2.2.x cluster or recompiles the 2.2.x client code with the check 
removed, then they could circumvent the check.  Adding a check on the server 
side would prevent this.  (Having the client-side check is still good too 
though.)

> disable symlinks temporarily
> ----------------------------
>
>                 Key: HADOOP-10020
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10020
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs
>    Affects Versions: 2.1.2-beta
>            Reporter: Colin Patrick McCabe
>            Assignee: Sanjay Radia
>            Priority: Blocker
>         Attachments: Hadoop-10020.patch
>
>
> disable symlinks temporarily until we can make them production-ready in 
> Hadoop 2.3



--
This message was sent by Atlassian JIRA
(v6.1#6144)

Reply via email to