[
https://issues.apache.org/jira/browse/HADOOP-10040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13793462#comment-13793462
]
Chris Nauroth commented on HADOOP-10040:
----------------------------------------
bq. Why not just make the line end conversion a build time thing?
I'd prefer to give Windows developers the right line endings for these files on
checkout. That way, they don't need to run a build or a manual unix2dos step
while testing changes made in the scripts.
In fact, one could say that it's never valid for these files to have Unix line
endings, because the files are only meaningful on Windows, which wants Windows
line endings. Even a developer editing the files on Unix and then copying them
to a Windows VM ought to maintain CRLF. It sounds like we can't fully
guarantee this for an svn checkout due to the svn-git interaction that Luke
pointed out. We'll be guaranteeing it for a git checkout though, which is the
more popular of the two.
> hadoop.cmd in UNIX format and would not run by default on Windows
> -----------------------------------------------------------------
>
> Key: HADOOP-10040
> URL: https://issues.apache.org/jira/browse/HADOOP-10040
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Yingda Chen
> Assignee: Chris Nauroth
> Fix For: 3.0.0, 2.2.1
>
>
> The hadoop.cmd currently checked in into hadoop-common is in UNIX format,
> same as most of other src files. However, the hadoop.cmd is meant to be used
> on Windows only, the fact that it is in UNIX format makes it unrunnable as is
> on Window platform.
> An exception shall be made on hadoop.cmd (and other cmd files for what
> matters) to make sure they are in DOS format, for them to be runnable as is
> when checked out from source repository.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
