[
https://issues.apache.org/jira/browse/HADOOP-10044?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jing Zhao updated HADOOP-10044:
-------------------------------
Attachment: HADOOP-10044.20131014.patch
Thanks Sanjay! The javadoc is very helpful to understand the RPC code. Some
minor comments about the current patch:
# In RpcConstants.java,
{code}
/**
* The Rpc-connection header is as follows
* +----------------------------------+
* | "hrpc" 4 bytes |
* +----------------------------------+
* | Version (1 byte) |
* +----------------------------------+
* | Service Class (1 byte) |
* +----------------------------------+
* | AuthProtocol (1 byte) |
* +----------------------------------+
*/
{code}
can be moved to somewhere in Server.java (e.g., as javadoc for Connection or
Connection#readAndProcess) ?
# In Connection#saslProcess, the AccessCotnrolException thrown by
processSaslMessage will be caught by the outside try-catch, and will be wrapped
as a WrappedRpcServerException. Thus we do not need to add it to signature and
javadoc.
# Do we need to javadoc the mechanism about how to create SASL server based on
different auth methods?
Besides there're some typos and I just modify them directly on the original
patch. Upload a new patch fixing typos.
> Improve the javadoc of rpc code
> -------------------------------
>
> Key: HADOOP-10044
> URL: https://issues.apache.org/jira/browse/HADOOP-10044
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Sanjay Radia
> Assignee: Sanjay Radia
> Priority: Minor
> Attachments: HADOOP-10044.20131014.patch, hadoop-10044.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.1#6144)
