[
https://issues.apache.org/jira/browse/HADOOP-9321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13804349#comment-13804349
]
Mit Desai commented on HADOOP-9321:
-----------------------------------
Ivan,
I reviewed the patch and here are some concerns that I have.
1) I see that you have imported everything under static.org.junit.Assert. Can
we not just import only what we need? That is: assertFalse, assertTrue,
assertSame & assertEquals. I tried with these changes and the tests works fine.
2) The comments describing the testSocksSocketFactory() and
testStandardSocketFactory() are same. Can you change the one for the
testStandardSocketFactory() so that the comments explains the tests properly?
3) In start(), the thread sleeps until the serverThread is running. Will the
thread sleep forever if the serverThread does not start at all or dies
instantly after it is created? I am not sure if the timeout helps overcome this
problem.
> fix coverage org.apache.hadoop.net
> -----------------------------------
>
> Key: HADOOP-9321
> URL: https://issues.apache.org/jira/browse/HADOOP-9321
> Project: Hadoop Common
> Issue Type: Test
> Affects Versions: 3.0.0, 2.3.0
> Reporter: Aleksey Gorshkov
> Assignee: Ivan A. Veselovsky
> Attachments: HADOOP-9321-trunk-a.patch, HADOOP-9321-trunk-b.patch,
> HADOOP-9321-trunk.patch
>
>
> fix coverage org.apache.hadoop.net
> HADOOP-9321-trunk.patch patch for trunk, branch-2, branch-0.23
--
This message was sent by Atlassian JIRA
(v6.1#6144)
