[
https://issues.apache.org/jira/browse/HADOOP-9723?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13828666#comment-13828666
]
Akira AJISAKA commented on HADOOP-9723:
---------------------------------------
Here are two comments:
1.
{code}
+ if (outFs.exists(outputPath)) {
+ throw new IOException("Archive path already exists");
+ }
+ if (outFs.isFile(dest)) {
+ throw new IOException("Archive destination is a file");
{code}
The following error messages seem to be better.
{code}
"Archive path: " + outputPath + " already exists"
"Archive destination: " + dest + " is a file"
{code}
2.
{code}
-import org.apache.hadoop.fs.FSDataInputStream;
-import org.apache.hadoop.fs.FSDataOutputStream;
-import org.apache.hadoop.fs.FileStatus;
-import org.apache.hadoop.fs.FileSystem;
-import org.apache.hadoop.fs.HarFileSystem;
-import org.apache.hadoop.fs.Path;
+import org.apache.hadoop.fs.*;
{code}
To avoid gratuitous diff/merge problems, you don't need to turn imports into *.
> Improve error message when hadoop archive output path already exists
> --------------------------------------------------------------------
>
> Key: HADOOP-9723
> URL: https://issues.apache.org/jira/browse/HADOOP-9723
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 3.0.0, 2.0.4-alpha
> Reporter: Stephen Chu
> Priority: Trivial
> Attachments: HADOOP-9723.patch
>
>
> When creating a hadoop archive and specifying an output path of an already
> existing file, we get an "Invalid Output" error message.
> {code}
> [schu@hdfs-vanilla-1 ~]$ hadoop archive -archiveName foo.har -p /user/schu
> testDir1 /user/schu
> Invalid Output: /user/schu/foo.har
> {code}
> This error can be improved to tell users immediately that the output path
> already exists.
--
This message was sent by Atlassian JIRA
(v6.1#6144)
