[ 
https://issues.apache.org/jira/browse/HADOOP-10171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13850653#comment-13850653
 ] 

Jonathan Eagles commented on HADOOP-10171:
------------------------------------------

Mit, Thanks for filing this issue and beginning the work. It really help move 
the Hadoop project allow. Couple of helpful (I hope) hints. I see the TestRPC 
test also fails on trunk in the same way, when running with JDK7. Perhaps let's 
update the summary to reflect the issue. In addition, I have been labeling jdk7 
issues with the java7 label to help track all issue that fail as part of the 
jdk7 migration. Lastly, the patch you have provided applies to branch-2 but not 
trunk. Here is how contributors navigate that scenario, though there is no 
rule. In general, work is contributed to trunk and then merged to appropriate 
branches. If a patch will apply to trunk and all destination branches, then 
name that patch like you have. If a patch is for a particular branch then the 
patch name should reflect the branch so as to reflect its destination 
(suggestion HADOOP-10171-branch-2.patch). A comment can be made describing the 
destination of each patch files attached to the jira. In the case like we have 
above please provide two separate patches, one for trunk and one for branch-2. 
In order not to confuse jenkins, attach the patch for trunk last, since jenkins 
will use the last attached file and apply that to trunk to produce the Hadoop 
QA test-patch report. This will allow you to submit your patch, while having 
patches for multiple branches. Sorry for the lengthy message, but hope that it 
helps.

Jon

> TestRPC fails on Branch-2
> -------------------------
>
>                 Key: HADOOP-10171
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10171
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 2.2.0
>            Reporter: Mit Desai
>            Assignee: Mit Desai
>         Attachments: HADOOP-10171.patch
>
>
> Branch-2 runs JDK7 which has a random test order. So we get an error in 
> TestRPC (testStopsAllThreads) failing on the AssertEquals.



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)

Reply via email to