[
https://issues.apache.org/jira/browse/HADOOP-9420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13864094#comment-13864094
]
Hadoop QA commented on HADOOP-9420:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12621770/HADOOP-9420-v2.txt
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:red}-1 findbugs{color}. The patch appears to introduce 4 new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3408//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3408//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-common.html
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3408//console
This message is automatically generated.
> Add percentile or max metric for rpcQueueTime, processing time
> --------------------------------------------------------------
>
> Key: HADOOP-9420
> URL: https://issues.apache.org/jira/browse/HADOOP-9420
> Project: Hadoop Common
> Issue Type: Bug
> Components: ipc, metrics
> Affects Versions: 2.0.3-alpha
> Reporter: Todd Lipcon
> Assignee: Liang Xie
> Attachments: HADOOP-9420-v2.txt, HADOOP-9420.txt
>
>
> Currently, we only export averages for rpcQueueTime and rpcProcessingTime.
> These metrics are most useful when looking at timeouts and slow responses,
> which in my experience are often caused by momentary spikes in load, which
> won't show up in averages over the 15+ second time intervals often used by
> metrics systems. We should collect at least the max queuetime and processing
> time over each interval, or the percentiles if it's not too expensive.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
