[ https://issues.apache.org/jira/browse/HADOOP-10208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13864430#comment-13864430 ]
Benoy Antony commented on HADOOP-10208: --------------------------------------- The findbugs are not related. The test failures are related. I'll look into it and fix the code. > Remove duplicate initialization in StringUtils.getStringCollection > ------------------------------------------------------------------ > > Key: HADOOP-10208 > URL: https://issues.apache.org/jira/browse/HADOOP-10208 > Project: Hadoop Common > Issue Type: Improvement > Affects Versions: 2.2.0 > Reporter: Benoy Antony > Assignee: Benoy Antony > Priority: Trivial > Attachments: HADOOP-10208.patch > > > The *values* is initialized twice. > {code:title=StringUtils.java|borderStyle=solid} > public static Collection<String> getStringCollection(String str){ > List<String> values = new ArrayList<String>(); > if (str == null) > return values; > StringTokenizer tokenizer = new StringTokenizer (str,","); > values = new ArrayList<String>(); > {code} -- This message was sent by Atlassian JIRA (v6.1.5#6160)