[
https://issues.apache.org/jira/browse/HADOOP-10178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13864587#comment-13864587
]
Chris Nauroth commented on HADOOP-10178:
----------------------------------------
Hi, Shanyu. The patch looks good. Just one minor thing: instead of catching
things like {{IOException}} inside the test and proceeding anyway, let's just
throw them out in the test method signature. If these happen during test runs,
then JUnit will print the full stack trace. That's potentially valuable for a
developer to identify problems like trying to run tests on a read-only volume,
out of space, permission problems, etc.
I'm +1 after that's addressed.
[~tucu00], you wrote the original HADOOP-8167 patch. Are you interested in
looking at this? I'll wait until Wednesday before committing in case you want
to comment.
> Configuration deprecation always emit "deprecated" warnings when a new key is
> used
> ----------------------------------------------------------------------------------
>
> Key: HADOOP-10178
> URL: https://issues.apache.org/jira/browse/HADOOP-10178
> Project: Hadoop Common
> Issue Type: Bug
> Components: conf
> Affects Versions: 2.2.0
> Reporter: shanyu zhao
> Assignee: shanyu zhao
> Attachments: HADOOP-10178-v2.patch, HADOOP-10178-v3.patch,
> HADOOP-10178.patch
>
>
> Even if you use any new configuration properties, you still find "deprecated"
> warnings in your logs. E.g.:
> 13/12/14 01:00:51 INFO Configuration.deprecation: mapred.input.dir.recursive
> is deprecated. Instead, use
> mapreduce.input.fileinputformat.input.dir.recursive
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
