[
https://issues.apache.org/jira/browse/HADOOP-10228?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Nauroth updated HADOOP-10228:
-----------------------------------
Component/s: fs
Affects Version/s: 2.2.0
Fix Version/s: 2.4.0
3.0.0
Hadoop Flags: Reviewed
+1 for the patch. Thanks, Haohui.
bq. -1 tests included. The patch doesn't appear to include any new or modified
tests.
This is an internal change, so there isn't a meaningful way to add a new unit
test that demonstrates it. The existing tests in {{TestFsPermission}} cover
the logic and protect against regressions.
bq. -1 core tests. The following test timeouts occurred in
hadoop-common-project/hadoop-common:
I don't see how this could be related. I applied the patch locally and ran the
test successfully.
> FsPermission#fromShort() should cache FsAction.values()
> -------------------------------------------------------
>
> Key: HADOOP-10228
> URL: https://issues.apache.org/jira/browse/HADOOP-10228
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 2.2.0
> Reporter: Haohui Mai
> Assignee: Haohui Mai
> Priority: Minor
> Fix For: 3.0.0, 2.4.0
>
> Attachments: HADOOP-10228.000.patch
>
>
> FsPermission#fromShort() calls FsAction.values() every time, which causes
> unnecessary performance penalty.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
