[ 
https://issues.apache.org/jira/browse/HADOOP-10232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13872836#comment-13872836
 ] 

stack commented on HADOOP-10232:
--------------------------------

bq. I added the annotation in 2.2 just to indicate that HBase does use this 
class.

If I do git blame, it says I added the annotation, not you.

{code}
bfc1e08c src/java/org/apache/hadoop/http/HttpServer.java                        
                  (Michael Stack           2011-06-02 18:54:40 +0000   93) 
@InterfaceAudience.LimitedPrivate({"HDFS", "MapReduce", "HBase"})
bfc1e08c src/java/org/apache/hadoop/http/HttpServer.java                        
                  (Michael Stack           2011-06-02 18:54:40 +0000   94) 
@InterfaceStability.Evolving
{code}

bq. I don't quite follow the value of putting in this patch right now.

The answer to the above is in your next sentence...

bq.  Indeed this patch can make Hbase compile against trunk right now

On the below....

bq. ...but I believe that the compatibility will be broken pretty soon (at 
least I plan to revisit this class in near term).

... is there a JIRA we can consult where what you are thinking is outlined?

bq. Therefore I would suggest to start the work of decoupling the class today.

Please tell us more what you are thinking regards refactoring.   We'd like to 
avoid being in a situation where say, we have jetty9 and jetty6 and all their 
dependencies trying to duke it out on the one downstream CLASSPATH (or poms 
full of crafted includes/excludes hard won after spending hours figuring what 
combination 'works').

Thanks.



> More options to HttpServer Builder
> ----------------------------------
>
>                 Key: HADOOP-10232
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10232
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 3.0.0
>            Reporter: Eric Charles
>         Attachments: HADOOP-10232-3.patch, HDFS-5760-1.patch, 
> HDFS-5760-2.patch
>
>
> o.a.h.h.HttpServer can can be instanciated and configured:
> 1. Via classical constructor
> 2. Via static build method
> Those 2 methods don't populate the same way the (deprecated) hostname and 
> port, nor the jetty Connector.
> This gives issue when using hbase on hadoop3 (HBASE-6581)



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to