[ 
https://issues.apache.org/jira/browse/HADOOP-10161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13874370#comment-13874370
 ] 

Hadoop QA commented on HADOOP-10161:
------------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  
http://issues.apache.org/jira/secure/attachment/12623559/HADOOP-10161_3_20140117.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-common-project/hadoop-common.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/3439//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/3439//console

This message is automatically generated.

> Add a method to change the default value of dmax in hadoop.properties
> ---------------------------------------------------------------------
>
>                 Key: HADOOP-10161
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10161
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: metrics
>            Reporter: Yang He
>         Attachments: HADOOP-10161_3_20140117.patch
>
>
> The property of dmax in ganglia is a configurable time to rotate metrics. 
> Therefore, no more value of the metric will be emit to the gmond, after 
> 'dmax' seconds, then gmond will destroy the metric in memory. In Hadoop 
> metrics framework, the default value of 'dmax' is 0. It means the gmond will 
> never destroy the metric although the metric is disappeared. The gmetad 
> daemon also does not delete the rrdtool file forever. 
> We need to add a method to configure the default value of dmax for all 
> metrics in hadoop.properties.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to