[
https://issues.apache.org/jira/browse/HADOOP-10241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris Nauroth updated HADOOP-10241:
-----------------------------------
Attachment: HADOOP-10241.1.patch
I'm attaching the patch. Summary:
# getfacl now uses {{PathData#toString}} so that it prints either the path's
full URI or just the path, depending on whether the user called the command
with a full URI or just path. This behavior is consistent with other commands
like ls.
# getfacl now prints a blank line after every path's ACL.
# The column formatting of ls now considers the possibility of an extra '+'
character on the end of the permission string to calculate padding.
There are no tests in this patch, because [~vinayrpet] plans to add a
comprehensive test suite for the new ACL CLI commands in HDFS-5702. For now, I
tested the changes manually by building a distro from the HDFS-4685 branch. I
also ran {{TestCLI}} and {{TestHDFSCLI}} to verify that there are no
regressions.
While working on this, I discovered an existing bug in the column formatting
for recursive ls. That's a trunk bug, so I'm not going to attempt to fix it
here. Instead, I reported the bug in HADOOP-10247.
> Clean up output of FsShell getfacl.
> -----------------------------------
>
> Key: HADOOP-10241
> URL: https://issues.apache.org/jira/browse/HADOOP-10241
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: HDFS ACLs (HDFS-4685)
> Reporter: Chris Nauroth
> Assignee: Chris Nauroth
> Attachments: HADOOP-10241.1.patch
>
>
> This patch will clean up a few formatting issues in the output of the getfacl
> command:
> # Currently, the file name is output as the full URI with "hdfs" scheme.
> We'll change this to print just the path portion for consistency with other
> shell commands like ls.
> # Print a blank line after printing an ACL. Linux getfacl does this. It's
> particularly helpful with getfacl -R, so that you get a visual indicator in
> between each returned ACL.
> # The '+' indicator appended to the permissions when the ACL bit is on throws
> off the nicely aligned table formatting of ls.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
