[
https://issues.apache.org/jira/browse/HADOOP-10255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13880023#comment-13880023
]
stack commented on HADOOP-10255:
--------------------------------
A few minor comments. (Is failure because patch build is against trunk and not
branch2, the target for this patch?)
nit: Should you leave the - @Deprecated in place?
nit: Do you want to explain in class comment why there is a class named
HttpServer2: i.e. 'this class exists because hbasers were whining when their
httpserver was taken away"? Folks may wonder expecially in h3 when HttpServer
is gone. Do you want to add 'yarn' to the list of LimitedPrivate or is
mapreduce suficient proxy for yarn?
Else looks good on quick review. +1 Above could be addressed on commit.
Thanks for doing this [~wheat9]
> Copy the HttpServer in 2.2 back to branch-2
> -------------------------------------------
>
> Key: HADOOP-10255
> URL: https://issues.apache.org/jira/browse/HADOOP-10255
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Haohui Mai
> Assignee: Haohui Mai
> Fix For: 2.4.0
>
> Attachments: HADOOP-10255.000.patch, HADOOP-10255.001.patch
>
>
> As suggested in HADOOP-10253, HBase needs a temporary copy of {{HttpServer}}
> from branch-2.2 to make sure it works across multiple 2.x releases.
> This patch renames the current {{HttpServer}} into {{HttpServer2}}, and bring
> the {{HttpServer}} in branch-2.2 into the repository.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
