[
https://issues.apache.org/jira/browse/HADOOP-10269?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13880083#comment-13880083
]
Ding Yuan commented on HADOOP-10269:
------------------------------------
Thanks for the response. It makes sense. I don't want to sound like a pest but
in this case this "ignored" is a different exception from se, and since the
code completely ignores it, later no one will ever know that there were another
exception "ignored" thrown by the dispose. Although 'dispose' shouldn't fail in
most cases, the purpose of an error handler is exactly to prepare for those
extremely rare cases where some failure modes are not anticipated. So in this
case maybe it's worthwhile to at least log this "ignored" exception?
> SaslException is completely ignored
> -----------------------------------
>
> Key: HADOOP-10269
> URL: https://issues.apache.org/jira/browse/HADOOP-10269
> Project: Hadoop Common
> Issue Type: Bug
> Components: security
> Affects Versions: 2.2.0
> Reporter: Ding Yuan
>
> In "org/apache/hadoop/security/SaslOutputStream.java", there is the following
> code pattern:
> {noformat}
> 172 try {
> 173 if (saslServer != null) { // using saslServer
> 174 saslToken = saslServer.wrap(inBuf, off, len);
> 175 } else { // using saslClient
> 176 saslToken = saslClient.wrap(inBuf, off, len);
> 177 }
> 178 } catch (SaslException se) {
> 179 try {
> 180 disposeSasl();
> 181 } catch (SaslException ignored) {
> 182 }
> 183 throw se;
> 184 }
> {noformat}
> On line 181, the exception thrown by disposeSasl(), which can be from
> SaslServer.dispose() or SaslClient.dispose(), is ignored completely without
> even logging it. Maybe at least log it?
> Ding
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
