[
https://issues.apache.org/jira/browse/HADOOP-10289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13882141#comment-13882141
]
Hadoop QA commented on HADOOP-10289:
------------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12625220/hadoop-10289.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 1 new
or modified test files.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3473//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3473//console
This message is automatically generated.
> o.a.h.u.ReflectionUtils.printThreadInfo() causes deadlock in TestHttpServer
> ---------------------------------------------------------------------------
>
> Key: HADOOP-10289
> URL: https://issues.apache.org/jira/browse/HADOOP-10289
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
> Affects Versions: 3.0.0, 2.4.0
> Environment: MacOS X 10.9/Java 6 1.6.0_65-b14-462
> Reporter: Laurent Goujon
> Fix For: 3.0.0
>
> Attachments: TestHttpServer.jstack, hadoop-10289.patch
>
>
> This bug is a followup on HADOOP-9964
> ReflectionUtils.printThreadInfo is now a synchronized method. This change
> creates sometimes deadlock situation in TestHttpServer if one servlet thread
> calling this method is waiting on client to consume output.
> In TestHttpServer, several tests connect to the http server only to check the
> status code but without reading the full inputstream. Depending on
> HttpURLConnection, the deadlock scenario may be triggered or not.
> Note that in the original ticket, it is not explained why synchronized fixed
> the issue. According to the attached stacktrace, test was blocked on
> HttpServer.stop(), waiting on worker threads to stop, which didn't happen
> because those threads were waiting for their output to be consumed, so the
> original issue looks very similar to what I'm experiencing.
> My proposed fix is to remove synchronized (as it seems to make the issue
> worse) but configure HttpServer.stop() to forcibly kill threads after a
> configurable period of time
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)