[ 
https://issues.apache.org/jira/browse/HADOOP-10288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13882908#comment-13882908
 ] 

Aaron T. Myers commented on HADOOP-10288:
-----------------------------------------

+1, the patch looks good to me, assuming that manual testing confirms that the 
fix works.

> Explicit reference to Log4JLogger breaks non-log4j users
> --------------------------------------------------------
>
>                 Key: HADOOP-10288
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10288
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: util
>    Affects Versions: 2.4.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: hadoop-10288.txt
>
>
> In HttpRequestLog, we make an explicit reference to the Log4JLogger class for 
> an instanceof check. If the log4j implementation isn't actually on the 
> classpath, the instanceof check throws NoClassDefFoundError instead of 
> returning false. This means that dependent projects that don't use log4j can 
> no longer embed HttpServer -- typically this is an issue when they use 
> MiniDFSCluster as part of their testing.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to