[
https://issues.apache.org/jira/browse/HADOOP-10297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13883799#comment-13883799
]
Hadoop QA commented on HADOOP-10297:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12625521/hadoop-10297.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs-httpfs.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3486//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3486//console
This message is automatically generated.
> FileChecksum should provide getChecksumOpt method
> -------------------------------------------------
>
> Key: HADOOP-10297
> URL: https://issues.apache.org/jira/browse/HADOOP-10297
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Laurent Goujon
> Attachments: hadoop-10297.patch
>
>
> o.a.h.f.FileSystem has several methods which accepts directly or indirectly a
> ChecksumOpt parameter to configure checksum options, but there's no generic
> way of querying checksum options used for a given file.
> MD5MD5CRC32FileChecksum used by DFSClient has a getChecksumOpt() but since
> not just DistributedFileSystem is accepting a ChecksumOpt argument, but any
> FileSystem subclass (although only DistributedFileSystem implements a
> specific behaviour), I suggest to make getChecksumOpt an abstract method of
> FileChecksum. This could be used by tools like DistCp to replicate checksum
> options for example.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)
