[ 
https://issues.apache.org/jira/browse/HADOOP-10278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13884720#comment-13884720
 ] 

Chris Li commented on HADOOP-10278:
-----------------------------------

Thanks for checking it out.

1. In a later patch I'll be introducing the ability to swap the call queue at 
runtime, which is essential for performance tuning without restarting the 
namenode. The FIFOCallQueue responds to methods needed to accomplish this 
transparently to the server.

2. I would have preferred this myself (and earlier versions did this), but we 
will need control of the locks to do runtime queue swapping. In any case, the 
FairCallQueue (which should be coming in subtask5) will use this same locking 
code, so refactoring it into the base makes things cleaner.

I will start uploading the other subtask patches

> Refactor to make CallQueue pluggable
> ------------------------------------
>
>                 Key: HADOOP-10278
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10278
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: ipc
>            Reporter: Chris Li
>         Attachments: subtask1.2.patch, subtask1.3.patch, subtask1.patch
>
>
> * Refactor CallQueue into an interface, base, and default implementation that 
> matches today's behavior
> * Make the call queue impl configurable, keyed on port so that we minimize 
> coupling



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to