[ 
https://issues.apache.org/jira/browse/HADOOP-10285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13915257#comment-13915257
 ] 

Arpit Agarwal commented on HADOOP-10285:
----------------------------------------

Thanks Chris,the patch looks good, couple of points:

# Can you please add a comment in the {{NameNodeRpcServer}} constructor 
explaining why the service RPC endpoint supports {{refreshCallQueue}}?
# Is it easy to add an end-end test case now that the client and server pieces 
are in place?

I am not sure if the {{TestHASafeMode}} failure is related. I can't repro it on 
OS X or Centos 6 with your changes. I think it is a Jenkins quirk and I am 
inclined to commit it even with the failure.

> Admin interface to swap callqueue at runtime
> --------------------------------------------
>
>                 Key: HADOOP-10285
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10285
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Chris Li
>         Attachments: HADOOP-10285.patch, HADOOP-10285.patch, 
> HADOOP-10285.patch, bisection-test.patch, bisection-test.patch, 
> bisection-test.patch, bisection-test.patch, bisection-test.patch
>
>
> We wish to swap the active call queue during runtime in order to do 
> performance tuning without restarting the namenode.
> This patch adds the ability to refresh the call queue on the namenode, 
> through dfsadmin -refreshCallQueue



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)

Reply via email to