[
https://issues.apache.org/jira/browse/HADOOP-10436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13947628#comment-13947628
]
Hadoop QA commented on HADOOP-10436:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12636862/HADOOP-10436.1.patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3716//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3716//console
This message is automatically generated.
> ToolRunner is not thread-safe
> -----------------------------
>
> Key: HADOOP-10436
> URL: https://issues.apache.org/jira/browse/HADOOP-10436
> Project: Hadoop Common
> Issue Type: Bug
> Components: util
> Reporter: Ajay Chitre
> Assignee: Tsuyoshi OZAWA
> Attachments: HADOOP-10436.1.patch
>
>
> ToolRunner class is not thread-safe because it uses GenericOptionsParser.
> The constructor of GenericOptionsParser uses 'OptionBuilder' which is a
> singleton class that uses instance variables. In other words, OptionBuilder
> is NOT thread safe. As a result, when multiple Hadoop jobs are triggered
> simultaneously using ToolRunner they end up stepping on each other.
> The easiest way to fix it is by making 'buildGeneralOptions' synchronized in
> GenericOptionsParser.
> private static synchronized Options buildGeneralOptions(Options opts) {
> If this seems like the correct way of fixing this, either we can provide a
> patch or someone can quickly fix it. Thanks.
> Ajay Chitre
> [email protected]
> Virendra Singh
> [email protected]
--
This message was sent by Atlassian JIRA
(v6.2#6252)
