[
https://issues.apache.org/jira/browse/HADOOP-10440?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13948196#comment-13948196
]
Hadoop QA commented on HADOOP-10440:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12636905/HADOOP-10440-patch
against trunk revision .
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. There were no new javadoc warning messages.
{color:green}+1 eclipse:eclipse{color}. The patch built with
eclipse:eclipse.
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 1.3.9) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 core tests{color}. The patch passed unit tests in
hadoop-common-project/hadoop-common.
{color:green}+1 contrib tests{color}. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3717//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/3717//console
This message is automatically generated.
> HarFsInputStream of HarFileSystem, when reading data, computing the position
> has bug
> ------------------------------------------------------------------------------------
>
> Key: HADOOP-10440
> URL: https://issues.apache.org/jira/browse/HADOOP-10440
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 2.3.0
> Reporter: guodongdong
> Assignee: guodongdong
> Attachments: HADOOP-10440-patch
>
>
> In the HarFsInputStream of HarFileSystem, when reading data by interface "int
> read(byte[] b)", "int read(byte[] b, int offset, int len)" wille be called
> and position wille be update, so position need not be update in interface
> "int read(byte[] b)"
> public synchronized int read(byte[] b) throws IOException {
> int ret = read(b, 0, b.length);
> if (ret != -1) {
> position += ret;
> }
> return ret;
> }
> /**
> *
> */
> public synchronized int read(byte[] b, int offset, int len)
> throws IOException {
> int newlen = len;
> int ret = -1;
> if (position + len > end) {
> newlen = (int) (end - position);
> }
> // end case
> if (newlen == 0)
> return ret;
> ret = underLyingStream.read(b, offset, newlen);
> position += ret;
> return ret;
> }
--
This message was sent by Atlassian JIRA
(v6.2#6252)
