[
https://issues.apache.org/jira/browse/HADOOP-10473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13963554#comment-13963554
]
Jing Zhao commented on HADOOP-10473:
------------------------------------
Two nits:
# The following change will duplicate the comment:
{code}
+
+ // Ensure no calls were dropped
{code}
# We can remove the following change:
{code}
- }
+ }
{code}
Other than this +1.
> TestCallQueueManager is still flaky
> -----------------------------------
>
> Key: HADOOP-10473
> URL: https://issues.apache.org/jira/browse/HADOOP-10473
> Project: Hadoop Common
> Issue Type: Bug
> Components: test
> Reporter: Tsz Wo Nicholas Sze
> Assignee: Tsz Wo Nicholas Sze
> Priority: Minor
> Attachments: c10473_20140408.patch
>
>
> testSwapUnderContention counts the calls and then interrupts as shown below.
> There could be call after counting the call but before interrupt.
> {code}
> for (Taker t : consumers) {
> totalCallsConsumed += t.callsTaken;
> threads.get(t).interrupt();
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.2#6252)
