[ 
https://issues.apache.org/jira/browse/HADOOP-10430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13964754#comment-13964754
 ] 

Alejandro Abdelnur commented on HADOOP-10430:
---------------------------------------------

[~owen.omalley], I assume you refer in the KeyShell.java, in the ListCommand 
subclass, execute() method. If so, using getKeysMetadata() is a single 
KeyProvider call to fetch the metadata for all keys while the old pattern would 
require 1+N calls to the KeyProvider with N being the number of keys: one to 
get all keys, and N to get the metadata for all keys. If the KeyProvider is 
local this is not a big issue, but if the key provider is a client/server 
implementation, this means 1+N network roundtrips instead of just 1. Because of 
this I think the current patch is correct.

> KeyProvider Metadata should have an optional description, there should be a 
> method to retrieve the metadata from all keys
> -------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-10430
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10430
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: security
>    Affects Versions: 3.0.0
>            Reporter: Alejandro Abdelnur
>            Assignee: Alejandro Abdelnur
>         Attachments: HADOOP-10430.patch, HADOOP-10430.patch, 
> HADOOP-10430.patch
>
>
> Being able to attach an optional description (and show it when displaying 
> metadata) will enable giving some context on the keys.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to