[
https://issues.apache.org/jira/browse/HADOOP-10490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13966101#comment-13966101
]
Haohui Mai commented on HADOOP-10490:
-------------------------------------
The patch looks good. Nit:
{code}
+ writer.close();
+ writer = null;
{code}
Some of these code can be removed. +1 after addressing the comments.
> TestMapFile and TestBloomMapFile leak file descriptors.
> -------------------------------------------------------
>
> Key: HADOOP-10490
> URL: https://issues.apache.org/jira/browse/HADOOP-10490
> Project: Hadoop Common
> Issue Type: Bug
> Components: test
> Affects Versions: 3.0.0, 2.4.0
> Reporter: Chris Nauroth
> Assignee: Chris Nauroth
> Priority: Minor
> Attachments: HADOOP-10490.1.patch
>
>
> Multiple tests in {{TestMapFile}} and {{TestBloomMapFile}} open files but
> don't close them. On Windows, the leaked file descriptors cause subsequent
> tests to fail, because file locks are still held while trying to delete the
> test data directory.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
