[ 
https://issues.apache.org/jira/browse/HADOOP-10500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968835#comment-13968835
 ] 

Daryn Sharp commented on HADOOP-10500:
--------------------------------------

+1 Looks good.  I'd suggest that maybe a {{@Before}} that calls 
{{ProxyUsers.refreshSuperUserGroupsConfiguration()}} to reset the config.  That 
way only tests that need to twiddle the proxy config will need to refresh, and 
it will guard against someone adding a new test and forgetting to explicitly 
refresh the config to reset it.  It's up to you.

> TestDoAsEffectiveUser fails on JDK7 due to failure to reset proxy user 
> configuration.
> -------------------------------------------------------------------------------------
>
>                 Key: HADOOP-10500
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10500
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: security, test
>    Affects Versions: 3.0.0, 2.4.0
>            Reporter: Chris Nauroth
>            Assignee: Chris Nauroth
>            Priority: Trivial
>         Attachments: HADOOP-10500.1.patch
>
>
> The proxy user configuration is held in a static variable.  Various tests in 
> {{TestDoAsEffectiveUser}} mutate this data.  JDK7 executes tests in a 
> different order than JDK6, so this can cause a failure if the state hasn't 
> been set explicitly to what the test needs.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to