[ 
https://issues.apache.org/jira/browse/HADOOP-10507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13973944#comment-13973944
 ] 

Hadoop QA commented on HADOOP-10507:
------------------------------------

{color:green}+1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12640791/HDFS-6205-0001.patch
  against trunk revision .

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 1 new 
or modified test files.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  There were no new javadoc warning messages.

    {color:green}+1 eclipse:eclipse{color}.  The patch built with 
eclipse:eclipse.

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 1.3.9) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 core tests{color}.  The patch passed unit tests in 
hadoop-common-project/hadoop-common.

    {color:green}+1 contrib tests{color}.  The patch passed contrib unit tests.

Test results: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/3811//testReport/
Console output: 
https://builds.apache.org/job/PreCommit-HADOOP-Build/3811//console

This message is automatically generated.

> FsShell setfacl can throw ArrayIndexOutOfBoundsException when no perm is 
> specified
> ----------------------------------------------------------------------------------
>
>                 Key: HADOOP-10507
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10507
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: fs
>    Affects Versions: 3.0.0, 2.4.0
>            Reporter: Stephen Chu
>            Assignee: sathish
>            Priority: Minor
>         Attachments: HDFS-6205-0001.patch, HDFS-6205.patch
>
>
> If users don't specify the perm of an acl when using the FsShell's setfacl 
> command, a fatal internal error ArrayIndexOutOfBoundsException will be thrown.
> {code}
> [root@hdfs-nfs ~]# hdfs dfs -setfacl -m user:bob: /user/hdfs/td1
> -setfacl: Fatal internal error
> java.lang.ArrayIndexOutOfBoundsException: 2
>       at 
> org.apache.hadoop.fs.permission.AclEntry.parseAclEntry(AclEntry.java:285)
>       at 
> org.apache.hadoop.fs.permission.AclEntry.parseAclSpec(AclEntry.java:221)
>       at 
> org.apache.hadoop.fs.shell.AclCommands$SetfaclCommand.processOptions(AclCommands.java:260)
>       at org.apache.hadoop.fs.shell.Command.run(Command.java:154)
>       at org.apache.hadoop.fs.FsShell.run(FsShell.java:255)
>       at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:70)
>       at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:84)
>       at org.apache.hadoop.fs.FsShell.main(FsShell.java:308)
> [root@hdfs-nfs ~]# 
> {code}
> An improvement would be if it returned something like this:
> {code}
> [root@hdfs-nfs ~]# hdfs dfs -setfacl -m user:bob:rww /user/hdfs/td1
> -setfacl: Invalid permission in <aclSpec> : user:bob:rww
> Usage: hadoop fs [generic options] -setfacl [-R] [{-b|-k} {-m|-x <acl_spec>} 
> <path>]|[--set <acl_spec> <path>]
> [root@hdfs-nfs ~]# 
> {code}



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to