[ https://issues.apache.org/jira/browse/HADOOP-10520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13974260#comment-13974260 ]
Uma Maheswara Rao G edited comment on HADOOP-10520 at 4/18/14 5:36 PM: ----------------------------------------------------------------------- Thanks for the patch Liu. HarFileSystem test has assert on FileSystem api {noformat} 2014-04-18 16:34:50,923 ERROR fs.TestHarFileSystem (TestHarFileSystem.java:testInheritedMethodsImplemented(318)) - HarFileSystem MUST implement public void org.apache.hadoop.fs.FileSystem.setXAttrs(org.apache.hadoop.fs.Path,java.util.List) throws java.io.IOException 2014-04-18 16:34:50,925 ERROR fs.TestHarFileSystem (TestHarFileSystem.java:testInheritedMethodsImplemented(318)) - HarFileSystem MUST implement public java.util.List org.apache.hadoop.fs.FileSystem.getXAttrs(org.apache.hadoop.fs.Path) throws java.io.IOException 2014-04-18 16:34:50,926 ERROR fs.TestHarFileSystem (TestHarFileSystem.java:testInheritedMethodsImplemented(318)) - HarFileSystem MUST implement public java.util.List {noformat} I think we have to add the API details in MustNotImplement. Some more nits: {code} + /** + * Get the xattrs of a file or directory. + * @param path + * @throws IOException + */ + public List<XAttr> getXAttrs(Path path, final List<XAttr> xAttrs) throws IOException { {code} xAttrs parameter missed in javadoc and also go parameter description I would like to see the javadoc details about the Xattr structure {code} if (other.name != null) + return false; {code} Please keep the braces and check other references. was (Author: umamaheswararao): Thanks for the patch Liu. HarFileSystem test has assert on FileSystem api {noformat} 2014-04-18 16:34:50,923 ERROR fs.TestHarFileSystem (TestHarFileSystem.java:testInheritedMethodsImplemented(318)) - HarFileSystem MUST implement public void org.apache.hadoop.fs.FileSystem.setXAttrs(org.apache.hadoop.fs.Path,java.util.List) throws java.io.IOException 2014-04-18 16:34:50,925 ERROR fs.TestHarFileSystem (TestHarFileSystem.java:testInheritedMethodsImplemented(318)) - HarFileSystem MUST implement public java.util.List org.apache.hadoop.fs.FileSystem.getXAttrs(org.apache.hadoop.fs.Path) throws java.io.IOException 2014-04-18 16:34:50,926 ERROR fs.TestHarFileSystem (TestHarFileSystem.java:testInheritedMethodsImplemented(318)) - HarFileSystem MUST implement public java.util.List {noformat} I think we have to add the API details in MustNotImplement. > Extended attributes definition and FileSystem APIs for extended attributes. > --------------------------------------------------------------------------- > > Key: HADOOP-10520 > URL: https://issues.apache.org/jira/browse/HADOOP-10520 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs > Reporter: Yi Liu > Assignee: Yi Liu > Fix For: 3.0.0 > > Attachments: HADOOP-10520.patch > > > This JIRA defines XAttr (Extended Attribute), it consists of a name and > associated data, and 4 namespaces are defined: user, trusted, security and > system. FileSystem APIs for XAttr include setXAttrs, getXAttrs, removeXAttrs > and so on. For more information, please refer to HDFS-2006. -- This message was sent by Atlassian JIRA (v6.2#6252)