[
https://issues.apache.org/jira/browse/HADOOP-10511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13974353#comment-13974353
]
Ravi Prakash commented on HADOOP-10511:
---------------------------------------
Hi Daniel!
Thanks a lot for your contribution. You're right that patch files are how we
accept contributions. We usually use SVN style patch file which you can
generate from git diff if you use --no-prefix
https://wiki.apache.org/hadoop/HowToContribute details these protocols.
Could you please guide me on how I can run the unit test you added? I removed
your changes in src/main and ran the unit test using
$ mvn -Dtest=NativeS3FileSystemContractBaseTest test
$ mvn -Dtest=NativeS3FileSystemContractBaseTest#testListStatusWithPassword test
No tests were actually run.
> s3n:// incorrectly handles URLs with secret keys that contain a slash
> ---------------------------------------------------------------------
>
> Key: HADOOP-10511
> URL: https://issues.apache.org/jira/browse/HADOOP-10511
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs/s3
> Reporter: Daniel Darabos
> Attachments: HADOOP-10511.patch
>
>
> This is similar to HADOOP-3733, but happens on s3n:// instead of s3://.
> Essentially if I have a path like "s3n://key:pass%[email protected]/test",
> it will under certain circumstances be replaced with "s3n://key:pass/test"
> which then causes "Invalid hostname in URI" exceptions.
> I have a unit test and a fix for this. I'll make a pull request in a moment.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
