[ 
https://issues.apache.org/jira/browse/HADOOP-10322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13978380#comment-13978380
 ] 

Benoy Antony commented on HADOOP-10322:
---------------------------------------

Patch looks good  [~daryn]. Uniqueness is required.
Looks like the pom file change is missing in the patch which causes the 
compilation issue.
I would prefer returning a Set<String>  instead of String[] . But if String[]  
is suitable for the caller, it will be better to add a comment indicating that 
the methods returns unique principal names. 
Let me know if you prefer me to make these changes.


> Add ability to read principal names from a keytab
> -------------------------------------------------
>
>                 Key: HADOOP-10322
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10322
>             Project: Hadoop Common
>          Issue Type: Improvement
>          Components: security
>    Affects Versions: 2.2.0
>            Reporter: Benoy Antony
>            Assignee: Benoy Antony
>         Attachments: HADOOP-10322.patch, HADOOP-10322.patch, 
> HADOOP-10322.patch, HADOOP-10322.patch, HADOOP-10322.patch, 
> HADOOP-10322.patch, HADOOP-10322.patch, HADOOP-10322.patch, 
> HADOOP-10322.patch, HADOOP-10322.patch, HADOOP-10322.patch, 
> HADOOP-10322.patch, HADOOP-10322.patch, javadoc-warnings.txt
>
>
> It will be useful to have an ability to enumerate the principals stored in a 
> keytab.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to