[
https://issues.apache.org/jira/browse/HADOOP-10517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13988921#comment-13988921
]
Swarnim Kulkarni commented on HADOOP-10517:
-------------------------------------------
[~tedyu] Thanks for the new patch. Out of curiosity, should we use the
IOUtils#closeQuietly[1] instead of nesting try/catch since we are anyways
pulling in the commons-io dep?
[1]
http://commons.apache.org/proper/commons-io/apidocs/org/apache/commons/io/IOUtils.html#closeQuietly(java.io.Closeable...)
> InputStream is not closed in two methods of JarFinder
> -----------------------------------------------------
>
> Key: HADOOP-10517
> URL: https://issues.apache.org/jira/browse/HADOOP-10517
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Ted Yu
> Priority: Minor
> Attachments: HADOOP-10517.1.patch.txt, hadoop-10517-v1.txt
>
>
> JarFinder#jarDir() and JarFinder#zipDir() have such code:
> {code}
> InputStream is = new FileInputStream(f);
> copyToZipStream(is, anEntry, zos);
> {code}
> The InputStream is closed in copyToZipStream() but should be enclosed in
> finally block.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
