[ 
https://issues.apache.org/jira/browse/HADOOP-10517?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chris Nauroth updated HADOOP-10517:
-----------------------------------

          Component/s: util
                       test
     Target Version/s: 3.0.0, 2.5.0
    Affects Version/s: 3.0.0
                       2.4.0
         Hadoop Flags: Reviewed

+1 for hadoop-10517-v1.txt.  I'll commit this.

> InputStream is not closed in two methods of JarFinder
> -----------------------------------------------------
>
>                 Key: HADOOP-10517
>                 URL: https://issues.apache.org/jira/browse/HADOOP-10517
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: test, util
>    Affects Versions: 3.0.0, 2.4.0
>            Reporter: Ted Yu
>            Assignee: Ted Yu
>            Priority: Minor
>         Attachments: HADOOP-10517.1.patch.txt, hadoop-10517-v1.txt, 
> hadoop-10517-v2.txt
>
>
> JarFinder#jarDir() and JarFinder#zipDir() have such code:
> {code}
>                  InputStream is = new FileInputStream(f);
>                  copyToZipStream(is, anEntry, zos);
> {code}
> The InputStream is closed in copyToZipStream() but should be enclosed in 
> finally block.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to