[
https://issues.apache.org/jira/browse/HADOOP-10583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13992902#comment-13992902
]
Alejandro Abdelnur commented on HADOOP-10583:
---------------------------------------------
a few comments on the patch:
* KeyProvider.java, has a false change.
* KeyShell.java #init(String[] args) method is all manual parsing, given that
you are fixing this, wouldn’t make sense to change this to use common-cli?
* KMSClientProvider.java, toString() should be {{"KMSClientProvider[" + kmsUrl
+ "]"}}, so it is clear that we are toStringing the provider.
> bin/hadoop key throws NPE with no args and assorted other fixups
> ----------------------------------------------------------------
>
> Key: HADOOP-10583
> URL: https://issues.apache.org/jira/browse/HADOOP-10583
> Project: Hadoop Common
> Issue Type: Bug
> Components: bin
> Reporter: Charles Lamb
> Assignee: Charles Lamb
> Priority: Minor
> Labels: patch
> Fix For: 3.0.0
>
> Attachments: HADOOP-10583.1.patch, HADOOP-10583.2.patch
>
>
> bin/hadoop key throws NPE.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
